Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_exactor #224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove_exactor #224

wants to merge 2 commits into from

Conversation

dkuku
Copy link

@dkuku dkuku commented Dec 11, 2024

This is deprecated for long time and breaks on elixir 1.18-dev

@coveralls
Copy link

coveralls commented Dec 13, 2024

Coverage Status

coverage: 92.297% (+0.07%) from 92.224%
when pulling 7179ada on dkuku:remove_exactor
into 9cf5dfa on parroty:master.

@coveralls
Copy link

Coverage Status

coverage: 92.297% (+0.07%) from 92.224%
when pulling 92f26cb on dkuku:remove_exactor
into 9cf5dfa on parroty:master.

@nathany-copia
Copy link

#223

end

def deps do
[
{:meck, "~> 0.8"},
{:exactor, "~> 2.2"},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also be removed from the mix.lock file

mix deps.clean --unused --unlock

@nathany-copia

This comment was marked as resolved.

@dkuku
Copy link
Author

dkuku commented Dec 15, 2024

@nathany-copia how did you fixed the module Finch is not available?
edit: removing _build fixes it

@parroty
Copy link
Owner

parroty commented Dec 26, 2024

I tried to address the build error on #227. Is this change still valid? If so, I appreciate if you could rebase against current master branch 🙇 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants